Closed
Bug 960088
Opened 10 years ago
Closed 10 years ago
Initialize the observer right away in start method in firefox/lib/modal-dialog.js
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr24 fixed)
People
(Reporter: cosmin-malutan, Assigned: cosmin-malutan)
References
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
whimboo
:
review+
whimboo
:
checkin+
|
Details | Diff | Splinter Review |
We need to initialize the observer for watching new modalls openings right away in start method without delay as this blocks bug 795398.
|
Assignee | |
Comment 1•10 years ago
|
||
Here is the patch for default branch. The reports from bug 795398, proves it doesn't broke anything.
Assignee: nobody → cosmin.malutan
Status: NEW → ASSIGNED
Attachment #8360450 -
Flags: review?(andrei.eftimie)
Attachment #8360450 -
Flags: review?(andreea.matei)
|
|
Assignee | |
Updated•10 years ago
|
status-firefox26:
--- → affected
status-firefox27:
--- → affected
status-firefox28:
--- → affected
status-firefox29:
--- → affected
status-firefox-esr24:
--- → affected
|
|
Assignee | |
Comment 2•10 years ago
|
||
Patch applies cleanly on all branches.
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8360450 [details] [diff] [review] patch v1.0 Review of attachment 8360450 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Make sure it also passes on all branches locally. I can land on default now with an updated commit message.
Attachment #8360450 -
Flags: review?(andrei.eftimie)
Attachment #8360450 -
Flags: review?(andreea.matei)
Attachment #8360450 -
Flags: review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8360450 [details] [diff] [review] patch v1.0 Landed on default: http://hg.mozilla.org/qa/mozmill-tests/rev/9899644d6073
Attachment #8360450 -
Flags: checkin+
|
|
||
Updated•10 years ago
|
|
|
Assignee | |
Comment 5•10 years ago
|
||
Patch applies cleanly on all branches: Aurora: http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be2e87e1 http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be2cea6a http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be2cf4d1 Beta: http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be2ea6bc http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be2e9642 http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be2e9432 Release: http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be37b3f3 http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be372f51 http://mozmill-crowd.blargon7.com/#/functional/report/50df0bef5c9d0b802925c134be371fb5
|
||
Comment 6•10 years ago
|
||
Landed backports: http://hg.mozilla.org/qa/mozmill-tests/rev/7cd3d76daf72 (mozilla-aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/66dc6e0c3f79 (mozilla-beta) http://hg.mozilla.org/qa/mozmill-tests/rev/44c4994c633d (mozilla-release) http://hg.mozilla.org/qa/mozmill-tests/rev/e848717e9bef (mozilla-esr24)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•