Closed
Bug 960242
Opened 10 years ago
Closed 10 years ago
Avoid "aTab is null" error with <iframe mozbrowser>
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: billm, Assigned: billm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1004 bytes,
patch
|
Details | Diff | Splinter Review |
I was debugging some stuff in the dom/browser-element code today and I get a ton of "aTab is null" errors. The problem is that these frames emit a DOMTitleChanged event that is handled by the tabbrowser element. They pass the |contentWin == contentWin.top| test because that's how <iframe mozbrowser> is supposed to work. But they're not tabs, so we get null when trying to find a tab for the window. This is a simple fix.
Attachment #8360612 -
Flags: review?(dao)
Comment 1•10 years ago
|
||
Is <iframe mozbrowser> something web content in the wild can and should use? Otherwise, I don't see why the DOMTitleChanged event would bubble up from one of tabbrowser's browsers.
Updated•10 years ago
|
Attachment #8360612 -
Flags: review?(dao)
Flags: needinfo?(wmccloskey)
Assignee | ||
Comment 2•10 years ago
|
||
I don't see the error anymore.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(wmccloskey)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•