960983 - Flash status strings are not localizable

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Théo Chevalier]

On devices with a flash, (Peak for instance), you can see "Flash: On", "Flash: Off", "Flash: Auto" when touching the flash setting icon in Camera App.

Those strings should be localizable.

Comment 1

[Francesco Lodolo [:flod]]

https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L35
https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L280

supports: ['off', 'auto', 'on']
supports: ['off', 'torch']

If I'm reading the code right the status is used also as a string.

Comment 2

[Théo Chevalier]

I think this line https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L844 should return

return _(name);

where name contains the values in supports: ['off', 'auto', 'on'] ?

"Flash:" seems hardcoded. GTG, will take a deeper look tonight

Comment 3

[Théo Chevalier]

Okay, I found where the string "Flash:" should be localized: https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/views/hud.js#L88

I'm trying to do the same thing as here https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/views/confirm.js#L24 (calling a template function), but it seems that even calling l10n.get('some string') doesn't work. It just prevents the app from starting, and there's nothing in the logcat. And of course, I have no idea why.

Flash modes should be localized here https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/views/hud.js#L36

Comment 4

[Théo Chevalier]

The strings have been removed from the UI on master, this bug is now invalid.