961092 - Update HomeListsProvider to use the SQLiteBridge

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[:Margaret Leibovic]

In bug 942288, we're using Sqlite.jsm to store data for home panels. We should update (and rename) HomeListsProvider to pull data from this DB when it does DB queries.

I want us to land bug 947506 before working on this, to make the naming more straightforward.

Comment 1

[:Margaret Leibovic]

I started a patch for this.

Comment 2

[:Margaret Leibovic]

Attachment: patch

With this patch, testHomeListsProvider still passes locally, but I haven't tried writing any tests to exercise the actual DB interaction part of this.

I also want to file a bug to rename HomeListsProvider -> HomeProvider, and rename/update the HomeListItems columns we have in BrowserContract to reflect what we're doing in HomeProvider.jsm.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8364094 [details] [diff] [review]
patch

Review of attachment 8364094 [details] [diff] [review]:
-----------------------------------------------------------------

This is a happy patch.

::: mobile/android/base/db/HomeListsProvider.java
@@ -71,5 @@
> -
> -    private boolean isTest(Uri uri) {
> -        String isTest = uri.getQueryParameter(BrowserContract.PARAM_IS_TEST);
> -        return !TextUtils.isEmpty(isTest);
> -    }

You'd be welcome to move any of this you wanted into the bridge provider....

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/daa0d522ed53

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/daa0d522ed53