Closed Bug 961351 Opened 10 years ago Closed 10 years ago

Clear button not visible when focusing on rocketbar

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file, 1 obsolete file)

Github pull request to master
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
When you focus on rocketbar from a brower chrome with a URL bar, the clear button should be present.
Attached file Github pull request Rocketbar branch (obsolete) — 

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/8c2a7611b33a4b9b9291ee57f99a5ca485991b06
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: Clear button not visible when focusing on rocketbar → [IN ROCKETBAR] Clear button not visible when focusing on rocketbar

    
    

    
  


  

        Attachment #8362056 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8363745 [details] [review]
Github pull request to master

This one is fairly simple, has been baking on rocketbar for several days, and is for a new feature. Going r=me on this as we have a green travis build.

        Attachment #8363745 -
        Flags: review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/3eae0b20d35471ffdee327694814768d2548ae13
Summary: [IN ROCKETBAR] Clear button not visible when focusing on rocketbar → Clear button not visible when focusing on rocketbar

    
    

    
  
(In reply to Kevin Grandon :kgrandon from comment #4)
> This one is fairly simple, has been baking on rocketbar for several days,
> and is for a new feature. Going r=me on this as we have a green travis build.

I really don't think you should be reviewing your own commits for new features landing on master Kevin, in future please ask for a review.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: