961522 - [ftu] typos in ftu: "pckodeLabel" should be "spckcodeLabel", "messasges" should be "messages"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request

The changes which landed in bug 926347 have some issues. I didn't change the text label keys/entities because it's either a typo fix or uses the correct label used in Settings which localizers also should look up from theirs locales.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8362279 [details] [review]
pull request

Sending the review to my official bugzilla account :)

Comment 4

[Preeti Raghunath(:Preeti)]

Pike

Please check if you agree that this is a late l10n issue.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 8362279 [details] [review]
pull request

For 1.3, I think we should leave the typo in the key. We should fix that typo on master, though.

The typo in simDefaultMessage is OK to fix.

The change to simSettingsMessage should have a key change, and I don't think it should land on 1.3.

I don't think I fully grokked how this relates to bug 926347, though. The diff there seems to overlap only partially.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

I've been syncing with Kaze as well, and now that we have translations for the labels with typos, is just the label we will need to retransalte again.

Definitely not a 1.3+, but will leave to the l10n guys to decide if we correct the typo in the labels and  retranslate.

Thanks.

Comment 7

[Axel Hecht [:Pike]]

My comment 5 should answer that.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Axel Hecht [:Pike] from comment #5)
> For 1.3, I think we should leave the typo in the key. We should fix that
> typo on master, though.
So should I alter the calls to this key so that they used the typo version?

> I don't think I fully grokked how this relates to bug 926347, though. The
> diff there seems to overlap only partially.
I checked and all changes in my pull request touch changes from bug 926347

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Archaeopteryx [:aryx] from comment #8)
> (In reply to Axel Hecht [:Pike] from comment #5)
> > For 1.3, I think we should leave the typo in the key. We should fix that
> > typo on master, though.
> So should I alter the calls to this key so that they used the typo version?
Forget it, it's not used in 1.3.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request for 1.3, v1

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request for 1.3, v2

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8362279 [details] [review]
pull request

r+ but not a blocker for 1.3

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8363995 [details] [review]
pull request for 1.3, v2

IMHO, not a blocker for 1.3

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Master: ac8a273809b5b160554e616bc5ef2d6fa026ce0e