962174 - Current Downloads and Weekly Downloads are not calculated correctly in the Review History

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P2)

Description

[Alex Lakatos[:AlexLakatos]]

Current Downloads is always 0 and Weekly Downloads are not calculated correctly in the Review History.

1. Go to any application in the marketplace
2. Click on the "Review History" button
3. Log in with a reviewer account
4. Check the Current Downloads and Weekly Downloads numbers

Expected Results:
4. The Current Downloads and Weekly Downloads numbers match the ones shown in the Statistics page for the app submitter

Actual Results:
4. The Current Downloads shows 0 and Weekly Downloads does not match the sum from each day of the week, shown on my app submission statistics page.

Comment 1

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/a91848d2

Download counts not properly get updated via Monolith nightly.

Comment 2

[Alex Lakatos[:AlexLakatos]]

Looked right now on dev. The total downloads matches the ones I get in the statistics page, but I don't know how the weekly downloads get calculated, they don't seem to match the results in the statistics page if I choose this week or the last 7 days.

Comment 3

[Victor Carciu]

Rob, can you please explain us how should we calculate the weekly downloads in order to correctly verify this bug?

Comment 4

[Rob Hudson [:robhudson]]

Roughly it should be the sum of the installs from the last 7 days that you see on the statistics page for the app. It may be a day behind since statistics are usually a day behind.

Comment 5

[Victor Carciu]

In this case, I think that we can re-open this bug because the weekly downloads from stats are different than the ones from reviewer history : http://screencast.com/t/oH4po6fviZ4

Comment 6

[Rob Hudson [:robhudson]]

Once the cron runs this should clean things up:
https://github.com/mozilla/zamboni/commit/5557d95 

Two things this updates:
1. This moves the cron call to happen later after stats are indexed and indexes from 8 days ago through 1 day ago.
2. Fixes a bug where weekly counts often returned zero.