Closed
Bug 962848
Opened 10 years ago
Closed 10 years ago
Port |Bug 957220 - Enable code to build from m-c's config/rules.mk copies|
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file, 1 obsolete file)
1.83 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #957220 +++ We need to port part 1 of bug 957220.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8364026 -
Flags: review?(florian)
Comment 2•10 years ago
|
||
What about this part of the original patch? diff --git a/build/pypng/png.py b/mail/app/png.py rename from build/pypng/png.py rename to mail/app/png.py diff --git a/build/png2ico.py b/mail/app/png2ico.py rename from build/png2ico.py rename to mail/app/png2ico.py
Assignee | ||
Comment 3•10 years ago
|
||
Sorry about that. This copies the files from mail/app to im/app, maybe not the best solution...but I don't have other ideas.
Attachment #8364026 -
Attachment is obsolete: true
Attachment #8364026 -
Flags: review?(florian)
Attachment #8364087 -
Flags: review?(florian)
Comment 4•10 years ago
|
||
Comment on attachment 8364087 [details] [diff] [review] port-bug-957220.diff v2 Looks good. I assume you have tested it.
Attachment #8364087 -
Flags: review?(florian) → review+
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #4) > Comment on attachment 8364087 [details] [diff] [review] > port-bug-957220.diff v2 > > Looks good. I assume you have tested it. My build complete successfully and still had the jump list icons, I considered that a sufficient test.
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/52e6bc271075
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•