962978 - TextureHost leaking mBuffer with OMTC on Linux

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Oleg Romashin (:romaxa)]

It seems like latest trunk leaking mBuffer data in TextureClient/TextureHost

Regression seems coming from:
http://hg.mozilla.org/mozilla-central/rev/a283c87bafd1

MemoryTextureClient::Allocate - does alloc mBuffer
MemoryTextureClient::~MemoryTextureClient - does not delete buffer because IsSharedWithCompositor == true

TextureParent::ActorDestroy in case Deletion:
does not call DeallocateSharedData because TEXTURE_DEALLOCATE_CLIENT =false and TEXTURE_DEALLOCATE_DEFERRED = true.

so we jump onto mTextureHost->ForgetSharedData - which just forget mBuffer. - leak

after all that we coming into MemoryTextureHost::DeallocateSharedData
where mBuffer already null so no deletion happens

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Don't drop mBuffer for deffered deallocate too early

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Don't drop mBuffer for deffered deallocate too early

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8364212 [details] [diff] [review]
Don't drop mBuffer for deffered deallocate too early

Review of attachment 8364212 [details] [diff] [review]:
-----------------------------------------------------------------

Oh my, thanks!

Comment 4

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a4736ea178

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9a4736ea178