963388 - Add support for nullable dictionary return values in callback and js-implemented codegen

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Bug 886110 looks like it'll need it, right Blake?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add support for nullable dictionary return values in callbacks and js-implemented bindings.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 8364822 [details] [diff] [review]
Add support for nullable dictionary return values in callbacks and js-implemented bindings.

Review of attachment 8364822 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +3870,5 @@
>  
> +        if type.nullable():
> +            dictLoc = "${declName}.SetValue()"
> +        else:
> +            dictLoc = "${declName}"

I'd do:

        dictLoc = "${declName}"
        if type.nullable():
            dictLoc += ".SetValue()"

@@ +3878,5 @@
>                              exceptionCodeIndented.define()))
>  
> +        if type.nullable():
> +            declType = CGTemplatedType("Nullable", declType)
> +            # XXXbz Should this check be isNullOrUndefined() instead?

Given that the conversion from ECMAScript type to WebIDL type would work like that, I'd say yes.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Made those changes and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/bbde82f0d314

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bbde82f0d314