963411 - Define error responses that FxAccountsIACHelper might emit

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I'm not sure what errors might be sent to the fxa settings app from the FxAccountsIACHelper.

My understanding is that the format of the errors is
  { error: <string> message,
    details: <object> errorDetails }

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I'm not sure, but I think this might well impact FTE as well (bug 949049).

ferjm, what's the best way for me to track down the possible responses/circumstances leading to errors?

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

The system app handles a pretty wide variety[1] of server errors, but it's not clear to me how FxAccountsIACHelper would handle these errors, and whether it would send a corresponding error to the settings app.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/fxa/js/fxam_errors.js

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

The full list of errors is at [1]. I would say that most of them are only interesting for the System app. Does the UX for FTU and/or Settings define any error scenario for these apps? I would just "console.error" the responses within the error callback of FxAccountsIACHelper methods for now.

[1] https://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccountsCommon.js#70

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks, ferjm!

I've got a UX review on the books for later this week, I'll make sure any cases are handled.

I know that at least one of these (the "already logged in" case) is currently not handled correctly by the gaia system app, it is showing an empty error overlay (no text, just a horizontal line and a button). I've opened https://bugzilla.mozilla.org/show_bug.cgi?id=963859 for that one, perhaps there'll be others.

I'm going to close this, since the description is vague, and i'll open bugs under fxa-fxos for specific error messages that need implementation.