963865 - browser_946320_tabs_from_other_computers.js test fails with Fxa enabled.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

The test browser_946320_tabs_from_other_computers.js checks that after simulating a user being signed into Sync, the relevant sync menu items appears.  This user simulation isn't suitable for Firefox Accounts, and thus the test fails.  We'll need to fix this before we can enable Fxa by default.

Comment 1

[:Gijs (he/him)]

(In reply to Mark Hammond [:markh] from comment #0)
> The test browser_946320_tabs_from_other_computers.js checks that after
> simulating a user being signed into Sync, the relevant sync menu items
> appears.  This user simulation isn't suitable for Firefox Accounts, and thus
> the test fails.  We'll need to fix this before we can enable Fxa by default.

What exactly goes wrong in fxa? Do you have a try run that demonstrates the problem? There are various sync tests that use a similar pattern...

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-963865-Fix-browser_946320_tabs_from_other_comput.patch

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8368320 [details] [diff] [review]
0002-Bug-963865-Fix-browser_946320_tabs_from_other_comput.patch

Review of attachment 8368320 [details] [diff] [review]:
-----------------------------------------------------------------

One day we should invent a testing .jsm that the xpcshell tests can share with the b-c tests, but not this day!

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/08d8f9e97fdd

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/08d8f9e97fdd