964280 - [b2gpopulate] Add command line option to override b2g start timeout

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Robert Wood [:rwood]]

When using b2gpopulate with the emulator on a slower-running VM, after populating the emulator with data, b2gpopulate times out when restarting b2g. Add a command line option to b2gpopulate to allow the user to override the default timeout of 60 seconds.

Comment 1

[Robert Wood [:rwood]]

This will require a change to both gaiatest and b2gpopulate.

Gaiatest (GaiaDevice) will need to be modified to be able to receive an optional timeout value in start_b2g.

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L757

Gaiatest will need to be updated and released first, before the change to b2gpopulate.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Let's try to get this in the upcoming gaiatest release.

Comment 3

[Robert Wood [:rwood]]

Attachment: 964280gaiatestpr.txt

This is the PR for the gaiatest part of the change.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8366609 [details] [review]
964280gaiatestpr.txt

r=me with the nit addressed.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Thanks, landed in:
https://github.com/mozilla-b2g/gaia/commit/89b1df359d8a554ca8912a09d45a36feaa58701c

Comment 6

[Robert Wood [:rwood]]

Thanks Dave!

Re-opening for the change required for b2gpopulate itself.

Comment 7

[Robert Wood [:rwood]]

Attachment: link to PR: https://github.com/mozilla/b2gpopulate/pull/12

Adding the corresponding PR for the b2gpopulate side.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8367293 [details] [review]
link to PR: https://github.com/mozilla/b2gpopulate/pull/12

See comments in pull request.

Comment 9

[Robert Wood [:rwood]]

Comment on attachment 8367293 [details] [review]
link to PR: https://github.com/mozilla/b2gpopulate/pull/12

Thanks Dave - changes made and PR updated

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8367293 [details] [review]
link to PR: https://github.com/mozilla/b2gpopulate/pull/12

Thanks! Landed in:
https://github.com/mozilla/b2gpopulate/commit/92bae023d72f9db5c5388fb78f489e1813b001cb