964388 - staff-only videos get featured for logged-in contributors

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect, P2)

Description

[[:philipp]]

when i go to https://air.mozilla.org/ and log in with the persona tied to my mozillian contributor profile, the featured videos section on the right side of the page changes, but then it also includes recordings that are marked as staff-only, which cannot be accessed subsequently.

since this is in some cases rather frustrating, it's probably better to hide the interesting stuff from us, that we cannot get to :))

Comment 1

[Peter Bengtsson [:peterbe]]

Thank you! That's regression I think. I know there is code to prevent that from happening. Clearly it's buggy. 

Interestingly, we're completely changing how "Featured Videos" works. Instead it's going to be called "Trending Events" and it's sorting will be based on hits and age and it's almost the same algorithm used by Hacker News home page. I'll try to assert that it works accordingly (with regards to privacy) in the new functionality.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/6073ac485a920ddee24d1e03cfd9efaef958484d
fixes bug 964388 - staff-only videos get featured for logged-in contributors

Comment 3

[Peter Bengtsson [:peterbe]]

Thanks for filing this philipp. It was easy to see where the mistake was and I was able to prove it with a new test specifically for this. 

Will probably go into production next week.