964434 - [curated groups] Groups that require membership requests should show a membership pending message

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - screenshot of feature suggestion on stage

The lack of a persistent status message for pending a curated group memberships could lead to confusion.

Steps to reproduce:
1. join a group a curated group that requires stewards approval; ex: https://mozillians.allizom.org/group/sf-monument/
2. notice the message, "Your membership request is pending approval by the group curator."
3. navigate away from the group page and then return (or simply refresh the page)

Expected:
The message persists. Optimally it would be nice if the message was in a more contextual placement, next to the join/leave group button.

Actual:
Upon refreshing the page the "Your membership request is pending approval by the group curator" message does not persist.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

This is blocking launch. 

:wbowling, can you suggest a good UI pattern for this?
:dpoirier, can you take it on?

Comment 2

[Dan Poirier [:dpoirier]]

I'll do an initial simple implementation, just displaying something simple next to the Leave Group button if the user's membership is pending, and hopefully :wbowling can design a final UI and modify from my starting point.

Comment 3

[Dan Poirier [:dpoirier]]

wbowling: initial implementation is at https://github.com/caktus/mozillians/tree/964434-membership-pending-message, let me know if you have questions, otherwise I'll leave the rest to you.

Comment 4

[Wray Bowling [:wbowling]]

Attachment: Screen Shot 2014-01-30 at 11.32.55 AM.png

dpoirier: Since Edit Group and Delete Group have been appearing inside the "details" box I'm inclined to move the "Leave Group" button up there too. Un-Curated groups don't have that little box though, right?

here's a mocked up 'status bar'. there might already be a standard one of these though.

Style notes to self:
element.style {
background-color: #F5F5DC;
color: #FF8F00;
display: block;
text-align: center;
margin: 20px 0;
border-radius: 3px;
padding: 4px;
}

Comment 5

[Dan Poirier [:dpoirier]]

If someone's membership request is pending, should we change the text on the "Leave Group" button? To something like "Cancel membership request", though that seems too long to put on a button?

Also, I think it makes more sense for the Join and Leave buttons to stay down by the membership list, rather than up in the group details. Right now, only the curator ever sees buttons in the group details, and that makes sense to me. The buttons there are for changing the group details, while the Join or Leave button has to do with my membership status.

Comment 6

[Wray Bowling [:wbowling]]

PR https://github.com/mozilla/mozillians/pull/792

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/ebf999d3d4c0f8bd70dcb438ec2035c936f49b0e
[Fix bug 964434] show a membership pending message

Squashed commits:
- cleaned up whitespace
- restored placement of join.leave buttons
- Styled pending status bar just above list of members. Moved “Leave Group” button into the info - box where other buttons appear.

https://github.com/mozilla/mozillians/commit/0bd129070abb4f2b89d5a00cfe6c460b349a2e13
Merge pull request #792 from caktus/964434-membership-pending-message

[Fix Bug 964434] membership pending message

Comment 8

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening:

It doesn't appear the 'membership pending' message persists.

steps to reproduce:
1. join a group that requires a curator to allow joining (https://mozillians.allizom.org/en-US/group/sf-monument/)
2. browse away from that group
3. return to that groups page

Expected:
A message should persist stating that membership is still pending.

Comment 9

[Matt Brandt [:mbrandt]]

Bumping back to fixed - stage has been updated with latest head.

Comment 10

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

QA verified on stage. Looks fantastic .. thank you for slipping this into the release.

Membership pending message now persists.