964488 - Bug 891705 seems to have broken --disable-ogg builds, with "content/media/encoder/VorbisTrackEncoder.h:11:10: fatal error: 'vorbis/codec.h' file not found"

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 891705 seems to have broken --disable-ogg builds. Before its cset landed, I could build; now I cannot.

In particular, I get this build failure (after I've hacked around the build failure from bug 964484):
{
content/media/encoder/VorbisTrackEncoder.h:11:10: fatal error: 'vorbis/codec.h' file not found
#include <vorbis/codec.h>
         ^
}

I'm not sure if this is because I'm missing some system library, or because I've disabled ogg support in my .mozconfig. Either way, this is a build error that we should be able to detect in configure.in and either turn off code as-appropriate  (e.g. disable MOZ_WEBM_ENCODER perhaps) or fail early with a helpful warning.

I think this is just related to --disable-ogg (and/or a related system library), but FWIW, here's my full mozconfig:
{
ac_add_options --enable-debug --disable-optimize
ac_add_options --disable-crashreporter
ac_add_options --disable-installer
ac_add_options --disable-updater
ac_add_options --enable-valgrind
ac_add_options --enable-warnings-as-errors
ac_add_options --enable-profiling
ac_add_options --disable-accessibility
ac_add_options --disable-gamepad
ac_add_options --disable-gstreamer
ac_add_options --disable-jsd
ac_add_options --disable-ogg
ac_add_options --disable-opus
ac_add_options --disable-universalchardet
ac_add_options --disable-necko-wifi
ac_add_options --disable-wave
ac_add_options --disable-webapp-runtime
ac_add_options --disable-webgl
ac_add_options --disable-webm
ac_add_options --disable-webrtc
ac_add_options --disable-webspeech
ac_add_options --without-intl-api
}

Comment 1

[Daniel Holbert [:dholbert]]

Resolving as FIXED by bug 964559 (which removed support for --disable-ogg, making this a non-issue).