964833 - Entering the edit mode in the Dialer call log is slow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The call log edit mode is slow like a slug. We are doing a few reflows and we try to do one animation per row.

It's not visible with a few items but on my phone with a full call log i can never see any of the animations and it takes forever. My feeling for now is that we should first remove the animation to save a lot of times, and then someone needs to try to reland some animations that works with 200 rows.

So this patch is about removing all animations when entering edit mode for the moment. Then a followup can be opened once this patch lands to add back usable animations.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Hey Vivien, how slow is slow like a slog? Do you have any information on how much reflow is occuring? Thanks!

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Mason Chang [:mchang] from comment #1)
> Hey Vivien, how slow is slow like a slog? Do you have any information on how
> much reflow is occuring? Thanks!

I don't have a measure handy. But if you do |make reference-workload-medium| in the $GAIA folder and then open the call log, you should see how fast it is.

Now if you compare it with the email app which is not doing any animations this is way much faster.

Comment 3

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15918

I'm removing all the animations because we couldn't see them in the first place.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8369541 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15918

r=me

The transition looked nice but even a reference-workload-light was enough to get 0 frames.

Comment 5

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/dfe33a3b6c32f242d9629220e5a90dae5b53bd50

This is a slight improvement, maybe a profile could give us more insights if needed. Let's close this for now, please open another bug if you still find it too slow.

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Anthony Ricaud (:rik) from comment #5)
> This is a slight improvement, maybe a profile could give us more insights if
> needed. Let's close this for now, please open another bug if you still find
> it too slow.

Yes please, open a follow up and make it block bug 837633.