964961 - The desktop platform selection block is bigger than other platforms

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace.firefox.com/developers/app/test-app-tvfve/payments/
2. Notice the device options

observed behavior:
Desktop block is much bigger than the other platforms. See screenshot.

Comment 2

[Mathieu Pillard [:mat]]

Changing the text to "Firefox Desktop" would solve this (and work for everyone assuming we don't translate the string differently in other languages)

Comment 3

[Victor Carciu]

Also , please note that all selections from "Paid\In-app" section are bigger than the ones from Free section : http://screencast.com/t/uJhIJtawaS

Comment 4

[Andy McKay]

This is as annoyingly as hell.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Andy McKay [:andym] from comment #4)
> This is as annoyingly as hell.

If I marked as P2 all the bugs that annoy me, every Marketplace bug would be a P2 :-P

I kid!

Comment 6

[Mathieu Pillard [:mat]]

This sounds like something that would easily solved without any weird hacks with using flexbox on the parent (and if the browser doesn't support it, so be it, it should degrade gracefully)

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Flexbox is not a weird hack. We should get comfortable using it.

But you could just fix this by increasing the height of all of the other boxes.

Comment 8

[Mathieu Pillard [:mat]]

I'm saying that using flexbox would *not* be a weird hack, but any other solution probably would :)

Comment 9

[Christopher Van Wiemeersch [:cvan]]

My bad :) You have the right idea. Amen!

Comment 10

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/2572

Comment 11

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/8dbd428918a8dbcc93b989b0a02d245cccc882b2

STR:
See comment 0, but also check app submission page, and in compatibility page, check both free & paid tabs (switching the app paid/free status as necessary).

Comment 12

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF35 (Win 7).
Postfix screencast http://screencast.com/t/OcAMOoCtLlN
Closing bug.