96542 - Link Properties: Clearing text does not allow removal of existing link

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[TucsonTester1]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.3+)
Gecko/20010821 Netscape6/6.1b1
BuildID:    20010821

Link Properties: The Link Properties context panel contains instructions that
cannot be followed.  The statement under the Link Location field says ``(Clear
text to remove existing link form page.),'' however clearing the text does not
allow removal of existing link.  The statement under the Link Location field
says ``(Clear text to remove existing link form page.)''  However if you do so
you have to replace the removed information with something in order to make the
[OK] button available once again.  When the Link Location field is blank the
[OK] button is greyed-out.  The parenthetical instruction implies that one
should be able to ``un-linkify'' a piece of text on a page by clearing the field
and clicking [OK].

Reproducible: Always
Steps to Reproduce:
          (1) Select the link and click Link toolbar icon, 
                    Link Selection from the menu command,
                    or Link Selection from the keyboard 
                    command
          (2) The target web page location appears in the
                    Link Location field
          (3) Following the instructions to clear the text
                    from the field


Actual Results:  The [OK] button is no longer available; it becomes greyed-out.

Expected Results:  Clicking [OK] should return user to the document being edited
and the former link is returned to mere plain text.

This may merely be a cosmetic flaw, instead of a failure in functionality.

Comment 1

[Kathleen :Brade]

-->cmanske

Comment 2

[Charles Manske]

Good catch. This regression was caused by the recent fix for bug 90230.

Comment 3

[Charles Manske]

Attachment: Fix.

Comment 4

[Charles Manske]

note that this fix removes the line:
SetElementEnabledById("MakeRelativeUrl", enable);
that was accidentally checked in with the fix to 90230. It has no effect, but
should be removed (it is part of the fix for bug 72583, which isn't finished yet.)

Comment 5

[kinmoz]

sr=[e-mail] with parens around the > check.

Comment 6

[Charles Manske]

As per kin's suggestion, the changed line will be:
var enable = insertNew ? (dialog.hrefInput.value.trimString().length > 0) : true;

Comment 7

[Kathleen :Brade]

r=brade

Comment 8

[Asa Dotzler [:asa]]

a=asa on behalf of drivers. 

Comment 9

[Charles Manske]

checked in.

Comment 10

[James Baxter]

Verified on 8-30 build