965831 - Double clicking to add a media clip adds two media clips

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

This came from user testing, and I'm not sure if we should change anything or not.

What kept happening is people would double click to add a media item from inside the media gallery editor, and end up with two clips or images, and not know they just added two. Then later, would get really confused when things are being doubled and not know how that happened.

I'm not a huge fan of changing it to a double click. Maybe both? Maybe just don't add the second clip? Maybe find a way to make it more obvious? Not sure.

Also bloated the number of layers needlessly.

Comment 1

[Vick Makifina]

Hi Scott,

I would appreciate the task of solving this bug, i have installed the bugzilla build environment already. I would like you to point to me where to start, or any suggestion will be much appreciated.

Thanks.

Comment 2

[Scott [:thecount] Downe]

Awesome!

This is the file where we deal with the media gallery editor, and the line that sets up the click event: https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/src/editor/media-gallery-editor.js#L275

thumbnailBtn is the thumbnail itself, so you can add other events to that easily enough.

What kind of solutions were you thinking of?

Some good places to start would be to try adding a dblclick event as well, so doing one or the other adds only one event.

This should work as long as we don't use dblclick for anything else.

Comment 3

[Mohammad AbuShady]

@Scott, I don't understand how to reproduce this, where is the `add media clip` button ?
I understand it's something from https://popcorn.webmaker.org ?

Comment 4

[Jon Buckley [:jbuck]]

It's the button I've circled in red: http://dl.dropbox.com/u/4403845/Screenshots/e7.png

Comment 5

[Mohammad AbuShady]

Ok, I realized that it only appears after pasting a link on the box above, I've forked it and I'm installing the npm packages to run this locally, I'll take a look at it tonight at home.

And thanks for the fast reply.

Comment 6

[Jon Buckley [:jbuck]]

No problem and let us know if you have any questions!

Comment 7

[Mohammad AbuShady]

I have a problem in the npm install, I think the problem is that there's a typo in the package name, notice there's a dash missing in the requested package.

npm ERR! Error: No compatible version found: underscore.string@'~2.2.0rc'
npm ERR! Valid install targets:
npm ERR! ["0.9.2","1.0.0","1.1.3","1.1.4","1.1.5","1.1.6","2.0.0","2.1.0","2.1.1","2.3.0","2.3.1","2.3.2","2.2.1","2.2.0-rc","2.3.3"]

Comment 8

[Scott [:thecount] Downe]

@jbuck: any thoughts on that?

Comment 9

[Jon Buckley [:jbuck]]

I just did a fresh install of the node modules and it checked out locally.

Mohammad - What version of npm and nodejs are you using? You can check by running `npm -v` and `node -v`.

My local versions are:

Jons-MacBook-Pro:popcorn.webmaker.org jon$ npm -v
1.4.3
Jons-MacBook-Pro:popcorn.webmaker.org jon$ node -v
v0.10.26

Comment 10

[Mohammad AbuShady]

npm version is 1.2.18 `node -v` on other hands doesn't write any thing which is weird, but the `npm install` reports that i have node 0.10.15 installed.

Comment 11

[Jon Buckley [:jbuck]]

Maybe it's installed as `nodejs` instead?

I'd try updating to nodejs v0.10.26, which should also update your version of npm. If it doesn't then try updating npm separately.

Comment 12

[Mohammad AbuShady]

yea I just noticed that, it's nodejs on my machine, node is some other package for something else, ill update and report back.

Comment 13

[Mohammad AbuShady]

Ok after updating node, the version numbers match yours, and `npm install` finished successfully, the server starts, but I get a white page of popcorn maker, the layout seems to be drawn ( the bottom border of the top nav appears ) but nothing else, just a white page, firebug only shows 1 error in requirejs

screenshot:https://dl.dropboxusercontent.com/u/14224314/Screenshot%20from%202014-03-10%2023%3A20%3A45.png

Comment 14

[Jon Buckley [:jbuck]]

That requirejs script error usually means that a script failed to load. Are there any HTTP 404s in your log there?

Comment 15

[Mohammad AbuShady]

Not really, all the files return 200, 304(not modified) and only 1 302(temp redirection) which is the jwplayer, all loading at the end.

The only error is the js error, not http errors

Comment 16

[Chris DeCairos (:cade)]

Popcorn Maker is no longer under active development.

https://learning.mozilla.org/blog/product-update-for-appmaker-and-popcorn-maker