Closed Bug 966374 Opened 10 years ago Closed 6 years ago

Race condition in AddonRepository.cancelSearch()

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: Irving, Unassigned)

References

Details

AddonRepository._repopulateCacheInternal(), and possibly several other internal and external AddonRepository APIs, perform callback-based async steps (e.g. AddonManager.getAddonsByIDs()) before issuing the actual XHR request and setting the AddonRepository._searching flag.

If an AddonRepository.cancelSearch() call comes in during the async steps before the XHR starts, it has no effect and the search will still be performed.
This code is gone as of bug 1263313
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.