Closed
Bug 966711
Opened 10 years ago
Closed 10 years ago
Use translateZ() for lockscreen fade-out transition
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed)
People
(Reporter: timdream, Assigned: timdream)
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #945082 +++ Please read bug 945082 comment 82. It looks like even though the transform is equal for transform: scale(2) and transform: perspective(1000px) translateZ(500px) The translateZ() does not result Gecko to create a 4x big layer so the performance is super smooth.
Assignee | ||
Comment 1•10 years ago
|
||
1.3? triage: please read Andreas' comment in bug 945082 comment 74.
blocking-b2g: --- → 1.3?
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8369158 [details] [review] mozilla-b2g:master PR#15889 will-change is helpful too here so I am adding that to CSS also. BenWa, could you quickly read the comments I left in CSS and see if they can be more accurate? Thanks.
Attachment #8369158 -
Flags: review?(gweng)
Attachment #8369158 -
Flags: feedback?(bgirard)
Assignee | ||
Comment 4•10 years ago
|
||
Alive, please stay in the loop and see if the same hack(?) can benefit app transition.
Flags: needinfo?(alive)
Assignee | ||
Updated•10 years ago
|
Attachment #8369158 -
Flags: feedback?(hshih)
Comment 5•10 years ago
|
||
There is a Gaia UI test failed but I don't know whether it's relevant or not. So I just re-run the job. If the patch: 1. Works as Jerry confirmed: consumes not 4X size buffer 2. Works as Tim described: make the animation smoother on a real device 3. Pass the test. Or the test is irrelevant. I'm glad to set review+, and then we can just adopt this wildly as a way to solve the scaling issue before we can find any better solution. However, as a reviewer I must say that right now I have no device on the hand, so I can't confirm the patch's effects by myself.
Comment 6•10 years ago
|
||
OK, it seems all recent tests were failed at the same test. So I would set the review+. Let's see how much performance this patch can help.
Updated•10 years ago
|
Attachment #8369158 -
Flags: review?(gweng) → review+
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #5) > There is a Gaia UI test failed but I don't know whether it's relevant or > not. So I just re-run the job. > > If the patch: > > 1. Works as Jerry confirmed: consumes not 4X size buffer See bug 945082 comment 82, bullet point 3. > 2. Works as Tim described: make the animation smoother on a real device > 3. Pass the test. Or the test is irrelevant. comment 6. > > I'm glad to set review+, and then we can just adopt this wildly as a way to > solve the scaling issue before we can find any better solution. However, as > a reviewer I must say that right now I have no device on the hand, so I > can't confirm the patch's effects by myself.
Assignee | ||
Comment 9•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/75e9691f02b9d18585c18a5434beeff39ee7ea20 I assume BenWa has read the patch because he had left me some feedback on Github, so I merge an amended patch according to his feedback.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Attachment #8369158 -
Flags: feedback?(hshih)
Attachment #8369158 -
Flags: feedback?(bgirard)
Comment 10•10 years ago
|
||
blocking per: please read Andreas' comment in bug 945082 comment 74.
blocking-b2g: 1.3? → 1.3+
Comment 11•10 years ago
|
||
Uplifted 75e9691f02b9d18585c18a5434beeff39ee7ea20 to: v1.3: bd2088581364782ff251feadfe90f4067d0a5364
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•