Closed Bug 966915 Opened 10 years ago Closed 10 years ago

Rocketbar search results are including contacts, but shouldn't be

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jsmith, Assigned: kgrandon)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review
Per a discussion with Peter, the rocketbar should not be showing contacts in the rocketbar search results. Right now, if you have a contact added & you search for it in the rocketbar, you will find it.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Github pull request
Comment on attachment 8369380 [details] [review]
Github pull request

Hey Dale - 

Could you review this if you have a minute? I would rather keep the code around and simply disable contacts for the time being. Let me know what you think.
Attachment #8369380 - Flags: review?(dale)
Comment on attachment 8369380 [details] [review]
Github pull request

https://github.com/mozilla-b2g/gaia/commit/8ea1ff3f509918039048e57da4e6803ed2e8c0cf

Would like to see this back in at some point
Attachment #8369380 - Flags: review?(dale) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: