Closed Bug 9670 Opened 25 years ago Closed 25 years ago

sched: Mac Clipboard- Streams for large data sets [PP]

Categories

(Core :: XUL, enhancement, P2)

PowerPC
All
enhancement

Tracking

()

VERIFIED FIXED

People

(Reporter: trudelle, Assigned: mikepinkerton)

References

Details

(Whiteboard: NOV-11 have fix, but cannot test. browser edit menu items disabled.)

Streams for large data sets (test & verify)	0.5 days	sdagley	0%
Mass changing all XPToolkit M10 feature 'bugs' to target as p2 enhancement for
M10
Blocks: 9673
Status: NEW → ASSIGNED
Summary: sched: Mac Clipboard- Streams for large data sets → sched: Mac Clipboard- Streams for large data sets [PP]
Whiteboard: .5 day
Blocks: 12669
Whiteboard: .5 day → feature doesn't work, see comments
tested, verification failed.

Crash in DataStruct::GetData on NS_ADDREFF(*aData) as *aData is NULL.  Actually
the data references several levels up the call chain are NULL so I'm not sure if
this is a problem with transferrable or not.  Rod?  Pink?
we could be running out of memory if the data is too large. We copy data about 20
times before it is placed on the clipboard. I'm working on fixing that. If that's
not it, then ignore me.
I don't think that's the problem as I'm just testing with a few hundred
characters with LARGE_DATASET_SIZE defined as 10 in nsTransferable.cp.
Whiteboard: feature doesn't work, see comments → need input from rods, mail has been sent requesting his comments
(I need more info) The only way to know, is to step through this line by until
get there. I assume it is on the paste? Start in the editor code, putting a
break point where they start the paste. It really should be pretty straight
forward. Let me know what you find out, I can help then.
Whiteboard: need input from rods, mail has been sent requesting his comments → got comments from rods, need to provide more data for him
Target Milestone: M10 → M11
actually the error occurs on a copy.  I'll try and get more data on this for you
next week (9/14) but I'll be working from FL and may not have input on this one
until I return (9/20)
*** Bug 12508 has been marked as a duplicate of this bug. ***
in tracking down a bug for eli, i ran into this same problem. I've fixed

transferable so that it doesn't crash anymore when the read from disk fails, but

I haven't looked into why the read from disk is failing in the first place.

FIgured i'd leave that for dagley ;)



steve, repull nsTransferable.cpp if you are looking at this from FL.
Whiteboard: got comments from rods, need to provide more data for him → 1+ day, got comments from rods, need to provide more data for him
Assignee: sdagley → pinkerton
Status: ASSIGNED → NEW
the problem turns out to be some unimplemented code in DataStruct::WriteCache

which results in no data to be written to the clipboard file on any platform.

This pinkerton believes is an unfinished remnant of his reworking of the

transferrable code for D&D so reassigning to pink as he's got the best

understanding of what the issues were that blocked completion of the code in the

first place.
Whiteboard: 1+ day, got comments from rods, need to provide more data for him → have fix, but cannot test. browser edit menu items disabled.
i have a fix, but can't do any testing because the edit menu items in browser are
all disabled.
fix checked in, but cannot test. marking fixed for m11.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Sorry for spam, re-assigning phillip's QA contact XPToolkit/XPWidget bugs to
claudius due to restructure
Whiteboard: have fix, but cannot test. browser edit menu items disabled. → NOV-11 have fix, but cannot test. browser edit menu items disabled.
so this is still waiting for the edit menu? What up with that? Is there a bug that this can depend
so I/we'll know when Edit is ready?
it appears you can do the testing in editor with cmd-c and cmd-v. does that help?
QA Contact: claudius → elig
qa=elig
Status: RESOLVED → REOPENED
Re-opening using 2000011108 build on Mac OS 8.6.

Specifically, copying a large data set (URL from bug #12541 ---
http://slip/projects/marvin/copy-paste/copy-large-text/shortpage.html) puts
nothing onto the clipboard.

(And, yes, I did do a workaround to avoid bug #14026, of clicking into the URL
field and then into the browser window. The copy took a full 5 seconds, but when
I tried to paste the results into BBEdit, the Clipboard was empty, and the Paste
menu item was disabled.)
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
eli, this is already covered in other bugs, notably 21847. This was mostly a

scheduling bug for things that haven't broken.



reresolving fixed.
Status: RESOLVED → VERIFIED
Sure; I've generalized the title of 21847 so that it more obviously includes
non-table cases. Thanks!
You need to log in before you can comment on or make changes to this bug.