967203 - Telemetry doesn't save pending pings on shutdown

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Roberto Agostino Vitillo (:rvitillo)]

Telemetry submissions are decreasing after fixing Bug 839794. It seems that pending pings are not saved properly on shutdown ("profile-before-change2") by TelemetryFile.savePingToFile due to the following error: "OS.File has been shut down." The error is not triggered by the xpcshell tests though.

Comment 1

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: Bug 967203 - Telemetry doesn't save pending pings on shutdown, v1

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8369669 [details] [diff] [review]
Bug 967203 - Telemetry doesn't save pending pings on shutdown, v1

Review of attachment 8369669 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryPing.jsm
@@ +894,5 @@
>        Telemetry.canRecord = false;
>        return;
>      }
> +
> +    AsyncShutdown.profileBeforeChange.addBlocker(

Telemetry uses profile-before-change2 specifically because many components use profile-before-change to collect their data.

You should rather add a phase sendTelemetry to AsyncShutdown, backed by notification profile-before-change2, and use this phase here.

@@ +901,5 @@
> +        this.uninstall();
> +        if (Telemetry.canSend) {
> +          return this.savePendingPings();
> +        } else {
> +          return Promise.resolve();

If we don't have to wait for anything, just don't return anything.

Comment 3

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: Telemetry doesn't save pending pings on shutdown, v2

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8370089 [details] [diff] [review]
Telemetry doesn't save pending pings on shutdown, v2

Review of attachment 8370089 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/77095ca6e53b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/77095ca6e53b

Comment 7

[Roberto Agostino Vitillo (:rvitillo)]

Comment on attachment 8370089 [details] [diff] [review]
Telemetry doesn't save pending pings on shutdown, v2

[Approval Request Comment]
The patch has landed a week ago and is needed to restore Telemetry's data collection.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ab0a84051348

Comment 9

[Bogdan Maris, Desktop QA]

Can this fix be tested manually? If so can you offer some steps in order to check that this issue is fixed?

Comment 10

[Roberto Agostino Vitillo (:rvitillo)]

Telemetry submissions recovered on the server side so the issue has been fixed (see http://ec2-50-112-66-71.us-west-2.compute.amazonaws.com:4352/#sandboxes/TelemetryChannelMetrics60DaysAggregator/outputs/TelemetryChannelMetrics60DaysAggregator.nightly.cbuf)