967215 - Fix fix_macosx_stack.py

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

There are at least two problems here. First, addresses use lower case letters, but the script is looking for upper case letters, so any address with a letter doesn't get converted.  Second, when you run atos, it spews out a warning, which confuses the script:

 -- 
Warning: /usr/bin/atos is moving and will be removed from a future OS X release.
It is now available in the Xcode developer tools to be invoked via: `xcrun atos`
To silence this warning, pass the '-d' command-line flag to this tool.
 -- 

I should either figure out how this xcrun thing should work (though maybe that will break older versions of OSX?), or just kick the can down the road and pass in '-d'.

Comment 1

[Andrew McCreight [:mccr8]]

With those fixed, the script actually seems to fix every line properly, at least in a simple test.

Comment 2

[Jesse Ruderman]

Can you upload your patch?

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Fix fix_macosx_stack.py

Comment 4

[Jesse Ruderman]

Regexp change looks good. For the "xcrun" change, maybe we can find someone with 10.8 to check that it still works on 10.8?

Comment 5

[Andrew McCreight [:mccr8]]

jwatt, njn said you know stuff about Xcode?  Do you have any idea what version "xcrun" was introduced by any chance?  I want to know if I can just unilaterally change a script over to do "xcrun atos" instead of "atos".

Comment 6

[Jonathan Watt [:jwatt]]

Sorry, that's not something I know.

Comment 7

[Nathan Froyd [:froydnj]]

xcrun lives on my somewhat-oldish XCode installation (4.4?  4.6?), on OS X 10.7.5.  The in-tree mozboot uses it.  I think it's safe to say it's been around for a while.

Comment 8

[Andrew McCreight [:mccr8]]

Comment on attachment 8369668 [details] [diff] [review]
Fix fix_macosx_stack.py

Maybe njn can get to this first.

Comment 9

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cff3bc2d1538

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cff3bc2d1538