Closed Bug 967411 Opened 10 years ago Closed 10 years ago

Fix a few widget leftovers in RequestsMenuView after bug 951633

Categories

(DevTools :: Netmonitor, defect)

Product:
DevTools
Component:
Netmonitor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 30

People

(Reporter: vporof, Assigned: vporof)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

v1
1.50 KB, patch
past
: review+
Details | Diff | Splinter Review 
Bug 951633 made a few changes to the widgets APIs. There are two small things in RequestsMenuView that haven't been updated:
* maintainSelectionVisible is a shared property now across all widget implementations
* a custom predicate should be supplied at initialization if sorting by values isn't desired
Attached patch v1 — — Splinter Review 
Assignee: nobody → vporof
Status: NEW → ASSIGNED

        Attachment #8369933 -
        Flags: review?(past)

    
    

    
  
Comment on attachment 8369933 [details] [diff] [review]
v1

Review of attachment 8369933 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

        Attachment #8369933 -
        Flags: review?(past) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f989ab51fa44
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Whiteboard: [qa-]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: