967508 - Write mochitests for services/fxaccounts

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

In order to avoid regressions like bug 967503 we need to write some mochitests apart from the already existing xpcshell tests.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

I'm working on this as part of Bug 943521.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Some mochitests will land with Bug 945363 and Bug 963835.

Comment 3

[Sam Penrose]

Jed marking this nice to have per Fernando's suggestion in bug 974123 -- place in your list TBD.

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

That's fine.  Mochitests are starting to trickle in with other patches, so we have a start.  But tests should be written for each method.

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

In addition to those mentioned in Comment 2, more will arrive when we land bug 947374 and bug 971379.

So this is moving forward on other fronts :)

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Hi, Fernando,

Over the past few weeks, we've grown a decent bunch of mochitests:

Bug 945363 has mochitests to ensure that RP callbacks fire in the correct sequence

Bug 947374 has mochitests for ensuring that only certified apps can declare a different assertion audience; the tests exercise watch/request for appStatuses 1, 2, and 3.

Bug 971379 has mochitests to ensure that only certified apps can call request() outside of a user event handler; it also has tests for appStatuses 1, 2, and 

Bug 974990 has mochitests for accept-language headers

Bug 978896 adds more mochitests to test how watch() and request() behave when there is or is not already a signed-in user.

I feel like we've got a pretty solid basic coverage with those tests.  Are there others that you think we ought to write?

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Thanks for adding all these tests Jed! This looks like a nice battery of tests, specially for the RP API.

It would also be great to have some marionette functional tests for B2G, do you know if there is any bug tracking this work?

Comment 8

[Sam Penrose]

Fernando this is bug 989368 .

Comment 9

[Sam Penrose]

I will mark this Resolved/Fixed unless one of you feels otherwise. bug 989368 is a project dependency and should not get lose.