967792 - Firefox unable to connect to WebSocket on localhost

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Randall Wood]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310

Steps to reproduce:

I have an application, JMRI (http://jmri.org), running on OS X 10.9. This application supports both HTTP and WebSockets clients on port 12080. I am running this application on the same host as the Firefox 26.0 client.


Actual results:

Firefox successfully makes HTTP requests when connecting to http://localhost:12080 and http://127.0.0.1:12080 without issue, but can only establish WebSocket connections to ws://127.0.0.1:12080; attempts to connect to ws://localhost:12080 fail.
Safari on the same computer successfully connects to ws://localhost:12080 and ws://127.0.0.1:12080 without issue.


Expected results:

I expected that Firefox would be able to establish the WebSocket connection to both localhost and 127.0.0.1 without issue.

Comment 1

[Junior [inactive]]

Attachment: offline-localhost

map localhost to 127.0.0.1 only in offline mode

Hello Patrick,
Could I have your review? 
Thanks.

Comment 2

[Junior [inactive]]

break the try; cancel the review, sorry
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d07bed7cd9e

Comment 3

[Patrick McManus [:mcmanus]]

Attachment: make localhost resolve offline

Comment 4

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fcd4019446f

Comment 5

[Patrick McManus [:mcmanus]]

The patch makes the resolution of localhost while offline preffable - with a default to true (i.e. yes - resolve). The reason I made it preffable was some tests were explicitly testing offline result codes and we require the test infrastructure to use localhost - so they need to be accommodated.

Comment 6

[Dragana Damjanovic [:dragana]]

Comment on attachment 8565018 [details] [diff] [review]
make localhost resolve offline

Review of attachment 8565018 [details] [diff] [review]:
-----------------------------------------------------------------

looks good.

Comment 7

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d168a14d3f71

Comment 8

[Carsten Book [:Tomcat]]

sorry had to back this out since i think this caused frequent OS X Test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=6670898&repo=mozilla-inbound

Comment 9

[Patrick McManus [:mcmanus]]

services/sync/tests/unit/test_errorhandler_sync_checkServerError.js needed  Services.prefs.setBoolPref("network.dns.offline-localhost", false) as the test actively probes offline behavior.

Comment 11

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13d9a5e39eb3

Comment 12

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4eca62dcfa57

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Backed out for Gaia unit test permafail.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7aebffd436c0

https://treeherder.mozilla.org/logviewer.html#?job_id=6972808&repo=mozilla-inbound

Comment 14

[Patrick McManus [:mcmanus]]

Junior- you'll need to debug that gaia pinyin test if you want to land this.. thanks!

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Nevermind, it wasn't yours after all (sorry). I've got it queued to re-land once I sort out what actually was at fault.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c49df0e00b59

Sorry again for the churn.

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c49df0e00b59