968023 - Remove nsISimpleEnumerator from import thread

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

otherwise thunderbird debug build causes a crash:

Hit MOZ_CRASH(nsCOMArrayEnumerator not thread-safe) at /home/zoe/hg/comm-central/mozilla/xpcom/glue/nsArrayEnumerator.cpp:128

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: bug968023.patch

Comment 2

[[e-mail]]

Comment on attachment 8370543 [details] [diff] [review]
bug968023.patch

> NS_IMETHODIMP GetSubFoldersRunnable::Run()
> {
>-  return m_folder->GetSubFolders(m_enumerator);
>+  return m_folder->GetSubFolders(nullptr);
This confused me briefly until I noticed that passing nullptr is an existing pattern here (normally that's not allowed for XPCOM out parameters).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/22a4aeca5215