Closed
Bug 968023
Opened 10 years ago
Closed 10 years ago
Remove nsISimpleEnumerator from import thread
Categories
(MailNews Core :: Import, defect)
MailNews Core
Import
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 30.0
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file)
4.65 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
otherwise thunderbird debug build causes a crash: Hit MOZ_CRASH(nsCOMArrayEnumerator not thread-safe) at /home/zoe/hg/comm-central/mozilla/xpcom/glue/nsArrayEnumerator.cpp:128
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8370543 [details] [diff] [review] bug968023.patch > NS_IMETHODIMP GetSubFoldersRunnable::Run() > { >- return m_folder->GetSubFolders(m_enumerator); >+ return m_folder->GetSubFolders(nullptr); This confused me briefly until I noticed that passing nullptr is an existing pattern here (normally that's not allowed for XPCOM out parameters).
Attachment #8370543 -
Flags: review?(neil) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/22a4aeca5215
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
You need to log in
before you can comment on or make changes to this bug.
Description
•