968029 - Use unprefixed box-sizing internally

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Alex Henrie]

All instances of -moz-box-sizing, -webkit-box-sizing, and -ms-box-sizing in the Mozilla codebase should be converted to the standard property box-sizing. WebKit and Trident dropped their prefixes long ago, and Gecko has recently done the same.

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=243412#c107
https://bugzilla.mozilla.org/show_bug.cgi?id=243412#c118

Comment 1

[Alex Henrie]

Attachment: Use unprefixed box-sizing in browser/extensions/pdfjs/

Comment 2

[Alex Henrie]

Attachment: Use unprefixed box-sizing in browser/ and toolkit/

Comment 3

[Alex Henrie]

Attachment: Use unprefixed box-sizing in mobile/android/

Comment 4

[Alex Henrie]

Attachment: Use unprefixed box-sizing in content/, dom/, layout/, and widget/

Comment 5

[Alex Henrie]

https://tbpl.mozilla.org/?tree=Try&rev=04d79930a29c

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8370556 [details] [diff] [review]
Use unprefixed box-sizing in mobile/android/

Looks fine. I didn't see any JS uses.
(also, saving margaret the review)

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8370557 [details] [diff] [review]
Use unprefixed box-sizing in content/, dom/, layout/, and widget/

r=dbaron

... although I already landed the parts in layout/reftests/w3c-css/submitted/ui3/  in https://hg.mozilla.org/integration/mozilla-inbound/rev/13f6dad08f3a , so those will need to be taken out of the patch


Also, one of us should (as a follow up) look into the tests that are using 'content' and 'padding' and 'border' (without the "-box") as values.  We used to support that a long time ago, and it seems likely that we should update the tests... assuming they still pass with the fix.

Comment 8

[Brendan Dahl [:bdahl]]

Comment on attachment 8370554 [details] [diff] [review]
Use unprefixed box-sizing in browser/extensions/pdfjs/

Review of attachment 8370554 [details] [diff] [review]:
-----------------------------------------------------------------

This also needs to make it upstream to https://github.com/mozilla/pdf.js/blob/master/web/viewer.css#L922.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

The CSS in aboutaccounts was imported from Web CSS, which explains the weird prefixes. Seems like we should probably also get rid of these there...

Comment 10

[Alex Henrie]

Attachment: Use unprefixed box-sizing in browser/extensions/pdfjs/

Rebased for checkin

Comment 11

[Alex Henrie]

Attachment: Use unprefixed box-sizing in content/, dom/, layout/, and widget/

Rebased for checkin

Comment 12

[Alex Henrie]

Requesting checkin of all 4 attached patches. Note that the third patch should be r=bdahl and the fourth patch should be r=dbaron.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6960aec45b20
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b95c9499474
https://hg.mozilla.org/integration/mozilla-inbound/rev/36459508cdac
https://hg.mozilla.org/integration/mozilla-inbound/rev/be8ad29ffc69

Please don't forget to get the pdf.js changes upstreamed so we don't accidentally revert them the next time we're syncing the in-tree copy with upstream.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6960aec45b20
https://hg.mozilla.org/mozilla-central/rev/8b95c9499474
https://hg.mozilla.org/mozilla-central/rev/36459508cdac
https://hg.mozilla.org/mozilla-central/rev/be8ad29ffc69