Closed Bug 968103 Opened 10 years ago Closed 10 years ago

Taping the cancel button in rocketbar always get you to the homescreen

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: etienne, Assigned: kgrandon)

References

Details

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
aus
: review+
Details | Review 
If you open the rocketbar from an app, then tap cancel to go out, you should get back to your app, not the homescreen.

Since I open it by accident a lot, it makes it even worse :/
I suppose you can tap on the card to open it :)

We need some UX decisions here I think. What if you close the current card or navigate to another card? 

Francis - any opinion on what to do here? I tried searching the spec but couldn't find these cases covered. Can we update the spec with something here?
Flags: needinfo?(fdjabri)
Blocks: rocketbar-search-mvp
Summary: Taping the cancel button in rocketbar alwas get you to the homescreen → Taping the cancel button in rocketbar always get you to the homescreen
I checked with Francis and Eric and we decided that cancel should open the currently active card if there is one.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Flags: needinfo?(fdjabri)
Attached file Github pull request — 
Aus - would you have time for a quick review?
Attachment #8371335 - Flags: review?(aus)
Comment on attachment 8371335 [details] [review]
Github pull request

Looks good Kevin!
Attachment #8371335 - Flags: review?(aus) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/8e036cd7fb9902ec60349540bb766cf38ac75093
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: