968122 - Clicking the everything.me bar shows dialogs in the background, causing the homescreen to be unusable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

In Firefox Nightly with a DEBUG profile, click the everything.me bar.

Now there is mayhem as you can't use the homescreen anymore.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

So what happens on FF Nightly is that the templates for the dialogs get filled when you click everything.me bar. I don't really know why that happens. The problem is that all the styling for these elements are in CSS files that will be lazy loaded when needed, causing the elements to show up with their default styles, which is why they are visible. There is no JS logic behind it either (also lazy loaded) so you can't dismiss it.

This patch adds a default style of display: none to the dialogs in homescreen.css that will be overwritten when we load the dialog CSS on demand. Tested it on the device as well and the context menu's still work as expected.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8370666 [details] [review]
Patch

Awesome, thanks for doing this!

Comment 3

[Cristian Rodriguez (:crdlc)]

Honestly, it should not happen because both are elements that haven't imported yet. So this patch works perfectly but it could hide the root issue thought

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/index.html#L53

Comment 4

[Kevin Grandon :kgrandon]

Yeah, my assumption was that E.me was trying to load some CSS but crashing/failing somewhere before it does.. It would probably be good to have an understanding of the root issue before landing.

Comment 5

[Cristian Rodriguez (:crdlc)]

Maybe Ran can have any idea

Comment 6

[Cristian Rodriguez (:crdlc)]

Ran, any thought? Thx mate

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Amir, do you?

Comment 8

[Amir Nissim (:amirn)]

Does not happen on device, I always assumed this is a Nightly issue.

Looks like lazy_loader.js behaves differently when DBEUG=1:
https://github.com/mozilla-b2g/gaia/blame/master/shared/js/lazy_loader.js#L43

Kevin?

Comment 9

[Kevin Grandon :kgrandon]

Yes, it behaves differently - but I don't think it should cause the issues shown. Instead of inlining elements, we just lazily load them.

It sounds like we need to just dig in to see exactly what's going on here.

Comment 10

[Jan Jongboom [:janjongboom] (inactive)]

Well, anyway, we're having a bunch of div's that have a display: block state whereas they should not be visible at all in default state (regardless of whether there is content in them) so we could land this anyway.

Then we can take a look at the reason why we populate the divs when we focus on the e.me bar.

Comment 11

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8370666 [details] [review]
Patch

OK, delete dialog and context menu work fine, thanks

Comment 12

[Jan Jongboom [:janjongboom] (inactive)]

Thanks Christian, https://github.com/mozilla-b2g/gaia/commit/e52cf841dc791f8c00748cd49c8e87d69f506041