968388 - Share button looks misaligned

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[u428464]

The share "plane button" doesn't show any effect on hover and has no clicked state. It should behave like other buttons in the toolbar.

Comment 1

[Tim Nguyen :ntim]

(In reply to Guillaume C. [:ge3k0s] from comment #0)
> The share "plane button" doesn't show any effect on hover and has no clicked
> state. It should behave like other buttons in the toolbar.

It does, but it's very random.

Comment 2

[u428464]

Attachment: Share button issues.png

Here's a screenshot of the current state. Not that entering customization and exiting makes the button take the right styling back.

Comment 3

[:Gijs (he/him)]

Guillaume, can you help me reproduce this? Or has the issue been resolved? On current Nightly, if I install the demo provider from http://mixedpuppy.github.io/socialapi-demo/, the share plane button that shows up seems to behave fine on Windows 7 in both aero and classic desktop themes...

Comment 4

[u428464]

Attachment: Still a bit misaligned.png

The hover styling is now fine, but the icon still looks a bit misaligned to the right. If it intended to be liked that feel free to close this bug.

Comment 5

[:Gijs (he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #4)
> Created attachment 8403982 [details]
> Still a bit misaligned.png
> 
> The hover styling is now fine, but the icon still looks a bit misaligned to
> the right. If it intended to be liked that feel free to close this bug.

Yeah, I think that's just because the plane is heading right, and so the visual balance of the icon makes it look uncentered. Stephen, is that right? If so, this should probably be resolved as worksforme. :-)

Comment 6

[:Gijs (he/him)]

(I doublechecked, and the icon has the right padding - it just looks, to a human eye, like it has more left padding because there's a big flat right side, and a narrow pointy left side with a lot of space above it - I guess we could change the padding to align the middle of the plane with the middle of the button, or something? There's enough excess padding to do this, but probably not a big deal either way, so taking the prio down a few notches...)

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: share-plane-alignment.patch - 01

Because of the shape and perspective on the icon it's never going to feel perfectly visually balance in its container. I moved the Share Plane over in its canvas as far as I could, which helps some.

Comment 9

[:Gijs (he/him)]

Comment on attachment 8576710 [details] [diff] [review]
share-plane-alignment.patch - 01

Review of attachment 8576710 [details] [diff] [review]:
-----------------------------------------------------------------

committed with further-compressed linux/Toolbar.png and osx/Toolbar{,-inverted}.png:


remote:   https://hg.mozilla.org/integration/fx-team/rev/2d79b9b2bbc4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2d79b9b2bbc4