Closed
Bug 968648
Opened 10 years ago
Closed 8 years ago
JavaScript Warning: "ReferenceError: reference to undefined property next.tagName"
Categories
(Toolkit :: Reader Mode, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jgilbert, Unassigned, Mentored)
Details
(Whiteboard: [good first bug][lang=js])
I saw this spew go by in my DEBUG android build on my Nexus 4: [JavaScript Warning: "ReferenceError: reference to undefined property next.tagName" {file: "chrome://browser/content/Readability.js" line: 262}] [JavaScript Warning: "ReferenceError: reference to undefined property next.tagName" {file: "chrome://browser/content/Readability.js" line: 346}]
Updated•10 years ago
|
Mentor: margaret.leibovic
Component: Readability → Reader Mode
Product: Firefox for Android → Toolkit
Whiteboard: [good first bug][lang=js]
Need some direction from dev: Was planning to take this. However, hitting chrome://browser/content/Readability.js in the browser yields a 404. where should I be looking for this file Readability.js in the source code? I couldn't find it under mobile/android/chrome/content/ Thanks, Shoubhik
Flags: needinfo?(margaret.leibovic)
Comment 2•9 years ago
|
||
Ah, sorry, this code moved since this bug was filed. You can now find the file here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/content/Readability.js
Flags: needinfo?(margaret.leibovic)
Comment 3•8 years ago
|
||
... and it was moved again to https://dxr.mozilla.org/mozilla-central/source/toolkit/components/reader/Readability.js
Comment 4•8 years ago
|
||
Fairly sure this has been fixed already. looking for next.tagName in Readability.js, all usecases are using checks to see that the next node is an Element, and those should have a tagName. Going to resolve as WFM, we should reopen if there are clear steps that still produce this issue.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•