968819 - HOST_OS_ARCH is different from OS_ARCH on BSDs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

Attachment: convert names

+++ This bug was initially created as a clone of Bug #959477 +++

When building on BSDs

1000    HOST_OS_ARCH=`echo $host_os | sed -e 's|/|_|g'`

while OS_ARCH takes `uname -s`-style values since bug 959477

982         dragonfly*)   OS_ARCH=DragonFly OS_TARGET=DragonFly ;;
983         freebsd*)     OS_ARCH=FreeBSD OS_TARGET=FreeBSD ;;
984         netbsd*)      OS_ARCH=NetBSD OS_TARGET=NetBSD ;;
985         openbsd*)     OS_ARCH=OpenBSD OS_TARGET=OpenBSD ;;

For example, on FreeBSD I have:

  HOST_OS_ARCH = freebsd11.0
  OS_ARCH = FreeBSD

Comment 1

[Jan Beich]

Attachment: convert names, v2

May as well add missing GNU platforms because on Debian I get

  HOST_OS_ARCH = kfreebsd11.0-gnu
  OS_ARCH = GNU_kFreeBSD

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8371509 [details] [diff] [review]
convert names, v2

Review of attachment 8371509 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +4371,5 @@
>                  ;;
>              WINNT)
>                  ICU_TARGET=MSYS/MSVC
>                  ;;
> +            DragonFly|FreeBSD|NetBSD|OpenBSD)

kFreeBSD is missing here (it was obviously caught with the previous wildcards ; i'm not sure it's a working configuration, but at least that matches what we have now).

Comment 3

[Jan Beich]

Attachment: convert names, v2.1 (rebased + kfreebsd fix)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1dfcb9ac6c8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1dfcb9ac6c8