Closed
Bug 968942
Opened 10 years ago
Closed 10 years ago
make SizeTyped constructors MOZ_CONSTEXPR to avoid static constructors
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
This is similar to what has already been done for IntSizeTyped.
Attachment #8371635 -
Flags: review?(bugmail.mozilla)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nfroyd
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8371635 [details] [diff] [review] make SizeTyped constructors MOZ_CONSTEXPR to avoid static constructors Review of attachment 8371635 [details] [diff] [review]: ----------------------------------------------------------------- Should the PointTyped and IntPointTyped constructors be doing this too? One of the IntPointTyped constructors already does it but the rest don't.
Attachment #8371635 -
Flags: review?(bugmail.mozilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2) > Should the PointTyped and IntPointTyped constructors be doing this too? One > of the IntPointTyped constructors already does it but the rest don't. Yeah, probably so. Want to see that patch?
Flags: needinfo?(bugmail.mozilla)
|
|
||
Comment 4•10 years ago
|
||
Rubber stamp! Assuming all our compilers are happy with it, I'm happy with it too.
Flags: needinfo?(bugmail.mozilla)
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6165b393a420
Flags: in-testsuite-
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6165b393a420
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•