969129 - Sandbox fails to build for b2g on OS X

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Eric Rahm [:erahm]]

Attachment: Potential fix

Seeing build errors attempting to build B2G on my OS X machine. Narrowed down to a #include of nsExceptionHandler in Sandbox.cpp. This breaks because MOZ_CRASHREPORTER is not defined for this target. The fix appears to be to ifdef out that code.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Looks good, and the seccomp crash reporter integration still works on a linux-hosted build.  Can you upload the patch in Hg format (or git-format-patch format)?

Comment 2

[Eric Rahm [:erahm]]

Attachment: fix_b2g_build.diff

Patched generated with git format-patch, let me know if this is the wrong format.

Comment 3

[Guillaume Destuynder [:kang] [this account is no longer active]]

normally it should have 8 lines of context diff, the git options in gitconfig are something like that:
[diff]
        git = 1
        unified = 8

or git format-patch -U8

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8371917 [details] [diff] [review]
fix_b2g_build.diff

Carrying over r=kang from previous version.

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

https://hg.mozilla.org/integration/b2g-inbound/rev/eb8002584068

Comment 6

[Carsten Book [:Tomcat]]

fixed on central https://hg.mozilla.org/mozilla-central/rev/eb8002584068

jld i guess the commit message has the wrong bugnumber which caused some confusion in bug 969126, could you make sure in the future to include the correct bugnumber (otherwise our merge tools gets confused) thanks :)

Comment 7

[Eric Rahm [:erahm]]

That was me, sorry for the confusion!