969275 - COPY_SEQUENCE_FIELD macro in NetworkUtils.h has coding error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Dimi Lee [ooo 16.04 - 21.04］]

There is an coding error in COPY_SEQUENCE_FIELD macro

Comment 1

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 969275 fix

Comment 2

[[:fabrice] Fabrice Desré]

Marking 1.3t+ since we took the worker rewrite on 1.3t.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8372139 [details] [diff] [review]
Bug 969275 fix

Review of attachment 8372139 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/NetworkUtils.cpp
@@ +231,5 @@
>    }
>  }
>  
> +static void split(char* str, const char* sep, nsTArray<nsString>& result)
> +{

It's redundant to have two similar functions doing almost the same thing. I really hope to see the follow-up bug to clean it. r=me for it really fixes the problem and is a 1.3T blocker.

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 969275 fix v2

Comment 5

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 969275 fix v3

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 969275 fix for 1.3t

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b0c83e05dfef

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0c83e05dfef

Comment 9

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/bcdfbf4dbf81