96957 - Sort order changed if you change thread-mode

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Håkan Waara]

Steps to reproduce:

1. Display a newsgroup as Messages > All
2. Change to Messages > Threads With Unread

The sort order is switched, from ascending to descending (and vice versa?).

Comment 1

[Håkan Waara]

I have a patch for this and another evil threadpane bug, bug 79588.

CCing folks for review.

Comment 2

[Håkan Waara]

Attachment: fix -- un-hardcode sortorder and threadmode where it's not needed.

Comment 3

[Doron Rosenberg (IBM)]

r=doron on patch, nice catch

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

looks harmless enough. 
sr=[e-mail]

Comment 5

[tor]

a=tor on behalf of drivers

Comment 6

[Håkan Waara]

fix checked in.

Comment 7

[Christoph]

This bug can still be seen with build 2001082803.  I did see this on bonsai the
other day as checked in, but then it disappeared the same day.

Comment 8

[Håkan Waara]

Cristoph, do you have a testcase to reproduce this bug in new builds?

Comment 9

[Christoph]

Nevermind - my mistake

Comment 10

[laurel]

Using aug29 commercial trunk build:
If I leave the View|All as default threaded/ascending then switch to
View|Threads with Unread, the view stays as threaded/ascending.
If I click the thread column to set the View|All to threaded/descending, when I
switch to View|Threads with Unread we reset to ascending.

So, we do change/reset to ascending when changing the view.  
I'm not sure we save ascending/descending in a lot of cases, so I'm a bit
confused about this particular fix -- we have an open bug about not saving on
switching sorts (bug 80936).  Wouldn't this (save across Views) just be an
extension of that bug?

Comment 11

[laurel]

OK, I think this is OK to mark verified. In the cases I've tried since, I've
used the Sort By menu to change Ascending/Descending and then I have no problem
when switching views (threaded).  So we may have an issue with the thread column
not changing necessary sort state in code somewhere...?  I'll play with that
more and log a separate report.

Comment 12

[Håkan Waara]

Laurel, feel free to CC me on that bug if you find one.