Closed
Bug 970276
Opened 10 years ago
Closed 10 years ago
Tab shows iframe's favicon instead of the top frame's favicon
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 30
Tracking | Status | |
---|---|---|
firefox30 | --- | verified |
People
(Reporter: ttaubert, Assigned: billm)
References
Details
(Keywords: regression)
Attachments
(2 files)
226 bytes,
text/html
|
Details | |
1.84 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
I have a bugzilla tab with a TBPL iframe that shows the TBPL favicon instead of the bugzilla favicon. I noticed this first after updating to today's Nightly. I suspect this might be a regression of bug 961529. Here's a link to a bug where that is happening with the BugzillaJS add-on installed that turns TBPL links into iframes: https://bugzilla.mozilla.org/show_bug.cgi?id=967766 It's probably not too hard to create an actual small test page to demonstrate the issue but OTOH this is probably equally easy to fix.
Comment 1•10 years ago
|
||
Updated•10 years ago
|
status-firefox30:
--- → affected
tracking-firefox30:
--- → ?
Assignee | ||
Comment 2•10 years ago
|
||
Thanks for the testcase. I really should have been more careful here. Looking at the code before my patch, it's pretty clear that the handlers for favicons, feeds, and search engines all want to ignore subframes. This patch just adds a central check.
Updated•10 years ago
|
Attachment #8373523 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/650fb3d50b5d
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/650fb3d50b5d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Reporter | ||
Updated•10 years ago
|
tracking-firefox30:
? → ---
Assignee | ||
Comment 7•10 years ago
|
||
I should probably write a test for this.
Flags: needinfo?(wmccloskey)
Comment 9•10 years ago
|
||
Verified on nightly 20140224180004 build
You need to log in
before you can comment on or make changes to this bug.
Description
•