970494 - Markers should be time based and not sample based

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Viktor Stanchev [:vikstrous]]

Right now markers are associated with samples. They should be associated with a time instead so that we can have markers between samples without losing their specific time information. This will also allow us to put comments between samples.

Comment 1

[Viktor Stanchev [:vikstrous]]

Attachment: marker_time

Comment 2

[Viktor Stanchev [:vikstrous]]

https://tbpl.mozilla.org/?tree=Try&rev=6de80ef0d437

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8375128 [details] [diff] [review]
marker_time

Review of attachment 8375128 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I think we should be using float. I made the mistake of using float elsewhere. We should switch to float instead of double.

::: tools/profiler/PseudoStack.h
@@ +134,3 @@
>  private:
>    char* mMarkerName;
> +  double mTime;

Do you mind packing this structure better? double first, then pointers then int.

Comment 4

[Viktor Stanchev [:vikstrous]]

Attachment: marker_time

Comment 5

[Benoit Girard (:BenWa)]

Backed out for try failure:
https://hg.mozilla.org/integration/mozilla-inbound/rev/233bf797652c

Comment 6

[Benoit Girard (:BenWa)]

I mean warnings as errors.

Comment 7

[Viktor Stanchev [:vikstrous]]

Attachment: marker_time

https://tbpl.mozilla.org/?tree=Try&rev=e34d0733beae

Comment 8

[Benoit Girard (:BenWa)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/93c87caa7855

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/93c87caa7855