970682 - Add loss, jitter, and RTT to about:webrtc

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Comment 1

[Byron Campen [:bwc]]

Once these are added to the stats API, we need to display them on about:webrtc.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Add RTT to about:webrtc

Try - https://tbpl.mozilla.org/?tree=Try&rev=f62c29c3ef6e

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Loss and jitter are covered by Bug 970686, so this is the last patch (i.e. no need to leave this open)

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8391431 [details] [diff] [review]
Add RTT to about:webrtc

Review of attachment 8391431 [details] [diff] [review]:
-----------------------------------------------------------------

Looks pretty much good, with just a minor concern.

::: toolkit/content/aboutWebrtc.xhtml
@@ +157,5 @@
>      if (stat.bytesReceived !== undefined) {
>        statsString += " (" + round00(stat.bytesReceived/1024) + " Kb)";
>      }
> +    statsString += " Lost: " + stat.packetsLost + " Jitter: " + stat.jitter;
> +    if (stat.mozRtt !== undefined) {

Is this expected to be undefined in normal operation?

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Byron Campen [:bwc] from comment #4)
> > +    if (stat.mozRtt !== undefined) {
> 
> Is this expected to be undefined in normal operation?

Yes, glad you asked. RTT is only included in the RTCP case on the outbound side.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/449272159e81

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/449272159e81