970688 - Use mozSettings for Web Results deviceId parameter

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Kevin Grandon :kgrandon]

Right now we do some crazy stuff with datastore, but using mozSettings seems much more straightforward. Not sure why I didn't suggest this before.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

In progress.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8400388 [details] [review]
Github pull request

Amir, Ran - could one of you guys review this one? Thanks!

Comment 3

[Amir Nissim (:amirn)]

Well, at least we found a Datastore API bug with our implementation :)
(https://bugzilla.mozilla.org/show_bug.cgi?id=986056#c8)

I will review.
Thanks Kevin.

Comment 4

[Amir Nissim (:amirn)]

adding reference to bug 957978 where deviceId sharing was implemented with Datastore API

Comment 5

[Amir Nissim (:amirn)]

looks good, added few small changes and a question on Github:
https://github.com/EverythingMe/gaia/commit/6f944a25ad401acaa004206e13788f284ee4e560

Comment 6

[Kevin Grandon :kgrandon]

Thanks Amir, that was really helpful. Issues have been addressed and the pull request is updated.

Comment 7

[Amir Nissim (:amirn)]

sorry for nitpicking :)
https://github.com/EverythingMe/gaia/commit/d7673cf81703b8b1b7d904101aeb08b3feb5a50d

Comment 8

[Amir Nissim (:amirn)]

Kevin, can please address Comment 7 and land (already r+)

Thanks.

Comment 9

[Kevin Grandon :kgrandon]

No, that's great :) I probably should've just taken the commit from your branch. Thanks for letting me know and the quick turnaround!

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8400388 [details] [review]
Github pull request

Going with r=amir, feel free to land any comments if you have any ran. Waiting on travis.

Comment 11

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/b86e36e616ae50a355f0b79bf7519bfa29da1582