Closed
Bug 971283
Opened 10 years ago
Closed 10 years ago
Preferences links to Terms of Service and Privacy Notice are too high and and too large
Categories
(Firefox :: Sync, defect, P2)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 30
People
(Reporter: rfeeley, Assigned: mak)
References
Details
(Whiteboard: p=2 s=it-30c-29a-28b.2 [qa!])
Attachments
(2 files, 3 obsolete files)
58.96 KB,
image/png
|
Details | |
3.15 KB,
patch
|
ttaubert
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Much like my city’s mayor, the links to the Terms of Service and Privacy Notice in Preferences are too high and too large. Current: https://www.dropbox.com/s/sk1yayd3ldx55kc/terms-current.png Proposed: https://www.dropbox.com/s/o5ettzd2c94ftn3/terms-proposed.png Please bump font size down, and align vertically with [?] icon.
Updated•10 years ago
|
Comment 1•10 years ago
|
||
Ryan, can you please attach new mockups or fix the linked ones? Thanks!
Flags: needinfo?(rfeeley)
Comment 2•10 years ago
|
||
Ryan mentioned in another bug (he probably meant this one) that BugzillaJS is the cause and he is right, sorry. Opening those images in new tabs works as expected.
Flags: needinfo?(rfeeley)
Updated•10 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Whiteboard: p=0 → p=2 s=it-30c-29a-28b.2
Updated•10 years ago
|
QA Contact: twalker
Whiteboard: p=2 s=it-30c-29a-28b.2 → p=2 s=it-30c-29a-28b.2 [qa+]
Assignee | ||
Comment 3•10 years ago
|
||
We can't easily align the links with the help icon, cause the help icon is actually a button part of the preferences dialog, it is part of the same area where you usually find Accept/Cancel buttons, and out of the prefpane containing sync prefs. It would require deeper changes or css hacks that may also be bogus on hi-dpi settings. in-content preferences won't have issues aligning, since there is no help icon at all there, and since those are the future target for prefs I don't think it's worth to spend time refactoring the preferences dialog to add links into the footer. This is what we can do easily, would that be enough?
Attachment #8380025 -
Flags: feedback?(rfeeley)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
the right patch...
Attachment #8380026 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
on top of the patch in bug 965032
Attachment #8380029 -
Attachment is obsolete: true
Updated•10 years ago
|
Priority: -- → P2
Assignee | ||
Comment 7•10 years ago
|
||
John, based on the mockup at https://bug976617.bugzilla.mozilla.org/attachment.cgi?id=8381490 we seem to be using the default font size for any links, should we use a smaller font size for the links specified here or keep everything at default font size?
Flags: needinfo?(jgruen)
Comment 8•10 years ago
|
||
Marco, let's make the link copy for Terms of Service/ Privacy Notice small. Otherwise links should be normal size.
Flags: needinfo?(jgruen)
Assignee | ||
Updated•10 years ago
|
Attachment #8380025 -
Flags: feedback?(rfeeley)
Assignee | ||
Comment 9•10 years ago
|
||
let's go with it
Attachment #8381421 -
Attachment is obsolete: true
Attachment #8383282 -
Flags: review?(ttaubert)
Comment 10•10 years ago
|
||
Comment on attachment 8383282 [details] [diff] [review] patch v3 Review of attachment 8383282 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8383282 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2789e24048c9
Target Milestone: --- → Firefox 30
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2789e24048c9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8383282 [details] [diff] [review] patch v3 [Approval Request Comment] Bug caused by (feature/regressing bug #): no regression User impact if declined: Sync preferences UI looks bad Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): styling changes, low risk String or IDL/UUID changes made by this patch: none
Attachment #8383282 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox29:
--- → affected
status-firefox30:
--- → fixed
Updated•10 years ago
|
Attachment #8383282 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 14•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e2d7499fa0b5 This needed [Australis] in the commit message to make the hg commit hook happy. Not sure if this needs backing out on Holly or not, though.
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Whiteboard: p=2 s=it-30c-29a-28b.2 [qa+] → p=2 s=it-30c-29a-28b.2 [qa!]
Updated•10 years ago
|
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
You need to log in
before you can comment on or make changes to this bug.
Description
•