971351 - Firefox Beta release notes redirect to 404 page

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

See https://support.mozilla.org/en-US/questions/986002 - it looks like in generating the final RC of 27, the notes link in the product is generated as a release version (losing the 'beta' in the url).

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

This comes from 
 http://hg.mozilla.org/build/tools/file/default/release/patcher-configs/mozBeta-branch-patcher2.cfg#l12

We didn't make any changes for the RC, perhaps we lost a redirect on www.mozilla.org ?

Comment 2

[Rail Aliiev [:rail]]

http://hg.mozilla.org/build/tools/rev/3b74f66321b1 shows that we have been using the same URL schema for previous betas as well... Sounds as a website issue to me too.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

The url usually comes from
 http://hg.mozilla.org/build/tools/file/default/lib/perl/Release/Patcher/Config.pm#l11
Note that it uses the app version (ie 28.0) rather than our 28.0bN style of labeling releases.

So, rather than a lost redirect, it looks more like our web page location changed for beta notes but we didn't realize we had something to update. Fair ?

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

You're right - I now realize that this is about the redirect that used to exist in our .htaccess file where we pointed http://www.mozilla.org/en-US/firefox/CURRENT_VERSION/releasenotes/ to http://www.mozilla.org/en-US/firefox/CURRENT_VERSIONbeta/releasenotes/  until the version was released. 

Pmac, I think this might be your area?

Comment 5

[Paul [:pmac] McLanahan]

Looks like maybe so. I'll see what I can find out and report back. It seems clear that we're in the right component now though. Thanks for the ping.

Comment 6

[Paul [:pmac] McLanahan]

Attachment: bug-971351.patch

I believe this should fix it. It's a reversion of r123807. We'll need to deal with this again when releasenotes move to bedrock, which is happening soon! (yaaaay!)

Comment 7

[Steven Garrity [:sgarrity]]

Comment on attachment 8381496 [details] [diff] [review]
bug-971351.patch

Review of attachment 8381496 [details] [diff] [review]:
-----------------------------------------------------------------

Discussed on IRC and this would likely re-break Bug 953131 (see r123802). pmac said he would update to be specific to 'releasenotes' only.

Comment 8

[Paul [:pmac] McLanahan]

Attachment: bug-971351.patch

Updated patch to only catch ".../releasenotes/" urls.

Comment 9

[Paul [:pmac] McLanahan]

I've actually since added a '$' to the end of the match URL just to be sure we're only getting what we want, but haven't yet updated the patch. In practice I think these will be mostly identical.

Comment 10

[Steven Garrity [:sgarrity]]

Comment on attachment 8381593 [details] [diff] [review]
bug-971351.patch

Review of attachment 8381593 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like this updated version assumes the URL will always end with the slash ("releasenotes/") - is that always the case?

Comment 11

[Steven Garrity [:sgarrity]]

Comment on attachment 8381593 [details] [diff] [review]
bug-971351.patch

Review of attachment 8381593 [details] [diff] [review]:
-----------------------------------------------------------------

Talked this through with pmac on IRC - the trailing slash would get added even if it wasn't included originally.

Comment 12

[Paul [:pmac] McLanahan]

Applied in r125058.

Comment 13

[Paul [:pmac] McLanahan]

Works in dev:

https://www-dev.allizom.org/en-US/firefox/28.0/releasenotes/

Pushing to stage and prod.

Comment 14

[Paul [:pmac] McLanahan]

Committed to prod in r125063.