971515 - [System2] Instantiable MediaRecording

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need media_recording.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: PR for this bug

put the PR here and wait for travis's signal.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8377498 [details] [review]
PR for this bug

Alive,

Please review this patch. It changes the followings:
1. wraps the MediaRecording as instantiable object
2. remove few useless variables
3. make media_recording.js, media_recording_test.js pass jshint

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8377498 [details] [review]
PR for this bug

Please fix bootstrap_test.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8377498 [details] [review]
PR for this bug

Hi alive,

Please review it again. I had updated the bootstrap_test.js. Thanks.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

PR for bubble-tea branch:
https://github.com/mozilla-b2g/gaia/pull/16588

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: PR for bubble tea

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to bubble tea:
https://github.com/mozilla-b2g/gaia/commit/37739cb918affe7080960a7525f6b7e0e81318bb

Comment 8

[[e-mail]]

backout because conflict with master https://github.com/mozilla-b2g/gaia/commit/7e27508768e45c7d2ce07f7a4314b2774f934c12

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Deassign myself.

It's so sad to see this back out. It's not a complex patch but just a wrapper. I may take it back when I am free.

Comment 10

[[e-mail]]

let me do it after new media_recording merged ;->

Comment 11

[[e-mail]]

new version https://github.com/mozilla-b2g/gaia/pull/17114

Comment 12

[[e-mail]]

all green, will ask for review till bubble-tea merged

Comment 13

[[e-mail]]

Attachment: pull request redirect to github

Comment 14

[[e-mail]]

Comment on attachment 8396967 [details] [review]
pull request redirect to github

travis looks good

Comment 15

[[e-mail]]

fixed addressed issue and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/2462d4102562ddd06d2dfeeb77c52507239e8292

thanks!