Closed
Bug 971639
Opened 10 years ago
Closed 10 years ago
[MediaEncoder] Support fragment 3GP format
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
RESOLVED
FIXED
1.4 S2 (28feb)
People
(Reporter: ayang, Assigned: ayang)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ft:multimedia-platform][m+])
Attachments
(1 file, 1 obsolete file)
24.06 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•10 years ago
|
||
1. Add '3gp9' brand name. 2. Add AudioSampleEntry and VisualSampleEntry boxes as the based class for audio/video codec box.
Assignee | ||
Updated•10 years ago
|
Attachment #8375393 -
Flags: review?(cpearce)
Blocks: MediaEncoder
Assignee | ||
Updated•10 years ago
|
Attachment #8375393 -
Flags: review?(cpearce)
Assignee | ||
Comment 2•10 years ago
|
||
1. Correct the class inheritance of SampleEntryBox, VisualSampleEntryBox, AudioSampleEntryBox, MP4AudioSampleEntryBox and AVCSampleEntryBox. 2. Add 3GP ftyp brand names. 3. Add 3GP, MP4 flags in ISOMediaWriter.h
Attachment #8375393 -
Attachment is obsolete: true
Attachment #8377363 -
Flags: review?(cpearce)
Updated•10 years ago
|
Target Milestone: --- → 1.4 S2 (28feb)
Updated•10 years ago
|
Whiteboard: [ft:multimedia-platform]
Comment 3•10 years ago
|
||
Comment on attachment 8377363 [details] [diff] [review] generate_3gp Review of attachment 8377363 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Sorry for the delay in reviewing this!
Attachment #8377363 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #3) > Comment on attachment 8377363 [details] [diff] [review] > generate_3gp > > Review of attachment 8377363 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good. Sorry for the delay in reviewing this! Thanks for review. :-)
Assignee | ||
Comment 5•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=cb4bf88c4beb
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/b217d48ad644
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b217d48ad644
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Component: Video/Audio → Video/Audio: Recording
Updated•10 years ago
|
Whiteboard: [ft:multimedia-platform] → [ft:multimedia-platform][m+]
You need to log in
before you can comment on or make changes to this bug.
Description
•