971852 - spidermonkey_build.py looks for gcc in two different places

Status: RESOLVED INVALID

(Release Engineering :: General, defect)

Description

[Steve Fink [:sfink] [:s:]]

The in-tree mozconfig expects gcc to be unpacked from tooltool into $topsrcdir/gcc. spidermonkey_build.py wants it in /tools/gcc. I'm not sure why my testing for bug 961314 didn't catch this.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Put gcc in both places it is looked for

Temporary fix: just put it both places. The $topsrcdir location seems weird to me, especially if you're going to compile other stuff. Then again, it doesn't require privileged access to put it into /tools, so maybe it's better after all. I'd like to land this now to fix the immediate problem, then argue out which one is right.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8374975 [details] [diff] [review]
Put gcc in both places it is looked for

Yuk.
Mozconfig change? Softlink?

Comment 4

[Armen [:armenzg]]

The merge changed the permission of the file to 644:
http://hg.mozilla.org/build/mozharness/rev/12453b8563f7

I pushed a fix to the file permissions:
http://hg.mozilla.org/build/mozharness/rev/a61497549829

Comment 5

[Phil Ringnalda (:philor)]

As few paid sheriffs as we have this week, it's going to be Amateur Hour before long, so I've hidden it on m-i, m-c, b-i, f-t and try.

Comment 6

[Steve Fink [:sfink] [:s:]]

Backing this fix out. I don't think I'll need it anymore at all.

http://hg.mozilla.org/build/mozharness/rev/8a6b8e3a949e - backed out d803d2c04be4
http://hg.mozilla.org/build/mozharness/rev/22a7de23d1db - backed out bad0aa60db7a