Closed
Bug 971900
Opened 10 years ago
Closed 10 years ago
onLocaleReady incorrectly elides onConfigurationChange call if urlBar doesn't exist
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
1.53 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
// The URL bar hint needs to be populated. TextView urlBar = (TextView) findViewById(R.id.url_bar_title); if (urlBar == null) { return; } final String hint = getResources().getString(R.string.url_bar_default_text); urlBar.setHint(hint); // Allow onConfigurationChanged to take care of the rest. onConfigurationChanged(getResources().getConfiguration()); That early return is probably a little over-zealous.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8407219 -
Flags: review?(nalexander)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8407219 [details] [diff] [review] onLocaleReady incorrectly elides onConfigurationChange call if urlBar doesn't exist. v1 Review of attachment 8407219 [details] [diff] [review]: ----------------------------------------------------------------- A comment explaining that |onLocaleReady| is for strings, whilst |onConfigurationChanged| is for device changes (that might not require strings) in the method comments of each would be good. Also, a log if urlBar doesn't exist? I'm not sure how scared I should be that having urlBar in GeckoApp is not a hard requirement...
Attachment #8407219 -
Flags: review?(nalexander) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/358d667d091b
Target Milestone: --- → Firefox 31
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/358d667d091b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•